-
Notifications
You must be signed in to change notification settings - Fork 285
[Android] Add linking type parameter to performance job configuration #4870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new linking_type parameter throughout the performance job tooling so that dashboards can distinguish static vs. dynamic linking.
- Added
linking_typefield and environment propagation in the Helix submission script - Exposed
--linking-typeCLI flag, default, and configuration inrun_performance_job.py - Updated Azure pipeline template to pass the new flag when set
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/send_to_helix.py | Added linking_type field and LinkingType environment var |
| scripts/run_performance_job.py | Introduced CLI flag, default value, and config propagation |
| eng/pipelines/templates/run-performance-job.yml | Conditionally include --linking-type in pipeline steps |
Comments suppressed due to low confidence (3)
scripts/run_performance_job.py:92
- Add validation for
linking_type(e.g. allow only "Static" or "Dynamic") and raise an error on invalid values to prevent misconfiguration.
linking_type: str = "Dynamic"
scripts/send_to_helix.py:71
- Update the argument parser help text or module docstring to describe the new
linking_typeparameter so users understand its purpose and accepted values.
linking_type: Optional[str] = None
scripts/run_performance_job.py:543
- Add or update unit/integration tests to verify that the
linking_typeargument is parsed correctly and propagated into theconfigurationsdictionary.
configurations["LinkingType"] = str(args.linking_type)
|
The internal pipeline |
LoopedBard3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 👍. We will also need to update the autofiling configuration to include the LinkingType. As this is not its own column in the ADX, it will need to be pulled out in the query for android tests, but I think that doing this parse is fine for now as the number of tests that need this should not be too high. @caaavik-msft any thoughts on whether we should add this as it's own column for ADX?
Correct. I updated the dashboard to filter based on this value. |
|
Cool. I think this is good to merge as the ADX column question can be answered next week and adding this in minimizes any mislabeled data. |
Description
This PR adds a linking‐type parameter to the configuration, allowing dashboards to compare static and dynamic linking.