-
Notifications
You must be signed in to change notification settings - Fork 288
Remove Tiger SDK jobs + reenable Windows CI #5095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Tiger SDK jobs + reenable Windows CI #5095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR claims to "Remove the Tiger SDK jobs (Windows and Ubuntu) as we have gotten a bit of overlap with the Viper machines," but the actual code changes contradict this description. The changes primarily enable Tiger SDK jobs in the public jobs section by uncommenting previously disabled machine configurations, while also cleaning up commented-out Tiger SDK references in the private jobs section where Viper machine equivalents already exist.
Changes:
- Uncommented/enabled multiple Tiger SDK job configurations (
win-x64,win-x86,ubuntu-x64) in the public jobs section - Removed commented-out Tiger SDK references from private jobs section where Viper machines are already configured
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jobTemplate: /eng/pipelines/templates/run-scenarios-job.yml | ||
| buildMachines: | ||
| #- win-x64 | ||
| - win-x64 |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states "Remove the Tiger SDK jobs" but this change actually enables/uncomments the win-x64 job. This appears to be re-enabling Tiger SDK jobs rather than removing them. Please verify if the PR description is accurate or if the code changes need to be revised.
DrewScoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Almost all failures are related to net10.0, will remove net10.0 builds in another PR shortly at which point we can more easily fix any other errors. Looking at the non-net10 micro windows error the run ran successfully and it was an issue with the send to helix connection. Merging. |
Remove the Tiger SDK jobs (Windows and Ubuntu) as we have gotten a bit of overlap with the Viper machines. Also reenable previously disabled Windows CI jobs.