Skip to content

Auto-detect runtime_flavor for wasm_coreclr micro benchmarks#5155

Merged
LoopedBard3 merged 2 commits intodotnet:mainfrom
LoopedBard3:FixWasmCoreCLRRuntimeType
Mar 17, 2026
Merged

Auto-detect runtime_flavor for wasm_coreclr micro benchmarks#5155
LoopedBard3 merged 2 commits intodotnet:mainfrom
LoopedBard3:FixWasmCoreCLRRuntimeType

Conversation

@LoopedBard3
Copy link
Copy Markdown
Member

For wasm_coreclr micro benchmark runs, runtime_flavor is not passed via YAML, causing RuntimeType to be set to 'None' in configurations. This means results never appear in test history or the perf autofiler.

Add auto-detection of runtime_flavor for wasm_coreclr micro benchmarks, setting it to 'coreclr', following the existing pattern used by Android and iOS scenarios. This fix does not modify wasm (mono) behavior to avoid breaking existing test history reports.

Fixes the same root cause as #5153 but with a more targeted approach that only affects wasm_coreclr.

This will fix the RunConfigurations from saving as {"CompilationMode":"wasm","RunKind":"micro","RuntimeType":"None"} to saving as {"CompilationMode":"wasm","RunKind":"micro","RuntimeType":"coreclr"}

For wasm_coreclr micro benchmark runs, runtime_flavor is not passed via
YAML, causing RuntimeType to be set to 'None' in configurations. This
means results never appear in test history or the perf autofiler.

Add auto-detection of runtime_flavor for wasm_coreclr micro benchmarks,
setting it to 'coreclr', following the existing pattern used by Android
and iOS scenarios. This fix does not modify wasm (mono) behavior to
avoid breaking existing test history reports.

Fixes the same root cause as dotnet#5153 but with a more
targeted approach that only affects wasm_coreclr.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes missing RuntimeType metadata for wasm_coreclr micro benchmark runs by auto-populating runtime_flavor so run configurations are stored with RuntimeType=coreclr (enabling test history and perf autofiler visibility), without changing existing wasm (mono) behavior.

Changes:

  • Add auto-detection to set args.runtime_flavor = "coreclr" for run_kind="micro" with runtime_type="wasm_coreclr".

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@LoopedBard3 LoopedBard3 requested a review from pavelsavara March 17, 2026 18:18
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@LoopedBard3 LoopedBard3 enabled auto-merge (squash) March 17, 2026 19:38
@LoopedBard3 LoopedBard3 merged commit e68dba7 into dotnet:main Mar 17, 2026
74 checks passed
@LoopedBard3 LoopedBard3 deleted the FixWasmCoreCLRRuntimeType branch March 17, 2026 21:05
@pavelsavara
Copy link
Copy Markdown
Member

@LoopedBard3
At https://pvscmdupload.z22.web.core.windows.net/reports/allTestHistory/TestHistoryIndexIndex.html link for wasm/coreCLR leads to 404. Is this the right place where we should be looking ?

@ilonatommy
Copy link
Copy Markdown
Member

ilonatommy commented Mar 18, 2026

This is the last successful run, there should be one measurement there already. All the newer jobs fail with:

Stage Build job run_performance_test_micro_coreclr_JIT_SVElinux__arm64_perfcobalt depends on unknown job build_linux_arm64_release_coreclr

since #5127 got merged. It requires changes to runtime 's yml: dotnet/runtime#125719. Maybe more datapoints will help (?).

@LoopedBard3
Copy link
Copy Markdown
Member Author

Due to the reports only getting generated once a day at the moment, we probably just didn't have any runs with this change yet. We may also need a few runs for the report to properly generate. I will double check this tomorrow and if we still don't have results, I will investigate further.

@pavelsavara
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants