Auto-detect runtime_flavor for wasm_coreclr micro benchmarks#5155
Auto-detect runtime_flavor for wasm_coreclr micro benchmarks#5155LoopedBard3 merged 2 commits intodotnet:mainfrom
Conversation
For wasm_coreclr micro benchmark runs, runtime_flavor is not passed via YAML, causing RuntimeType to be set to 'None' in configurations. This means results never appear in test history or the perf autofiler. Add auto-detection of runtime_flavor for wasm_coreclr micro benchmarks, setting it to 'coreclr', following the existing pattern used by Android and iOS scenarios. This fix does not modify wasm (mono) behavior to avoid breaking existing test history reports. Fixes the same root cause as dotnet#5153 but with a more targeted approach that only affects wasm_coreclr. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes missing RuntimeType metadata for wasm_coreclr micro benchmark runs by auto-populating runtime_flavor so run configurations are stored with RuntimeType=coreclr (enabling test history and perf autofiler visibility), without changing existing wasm (mono) behavior.
Changes:
- Add auto-detection to set
args.runtime_flavor = "coreclr"forrun_kind="micro"withruntime_type="wasm_coreclr".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@LoopedBard3 |
|
This is the last successful run, there should be one measurement there already. All the newer jobs fail with: since #5127 got merged. It requires changes to runtime 's yml: dotnet/runtime#125719. Maybe more datapoints will help (?). |
|
Due to the reports only getting generated once a day at the moment, we probably just didn't have any runs with this change yet. We may also need a few runs for the report to properly generate. I will double check this tomorrow and if we still don't have results, I will investigate further. |
For wasm_coreclr micro benchmark runs, runtime_flavor is not passed via YAML, causing RuntimeType to be set to 'None' in configurations. This means results never appear in test history or the perf autofiler.
Add auto-detection of runtime_flavor for wasm_coreclr micro benchmarks, setting it to 'coreclr', following the existing pattern used by Android and iOS scenarios. This fix does not modify wasm (mono) behavior to avoid breaking existing test history reports.
Fixes the same root cause as #5153 but with a more targeted approach that only affects wasm_coreclr.
This will fix the RunConfigurations from saving as
{"CompilationMode":"wasm","RunKind":"micro","RuntimeType":"None"}to saving as{"CompilationMode":"wasm","RunKind":"micro","RuntimeType":"coreclr"}