Avoid picking implicit framework defines#3579
Merged
davkean merged 1 commit intodotnet:masterfrom May 27, 2018
Merged
Conversation
Fixes: dotnet#2720 The SDK automatically appends to DefineConstants with implicit constants after the project's definition of DefineConstants, when we read the value at the end of project file ("AfterContext") we think that user's value is set to include those when we re-read it. Instead move to reading the value *at the point* it was defined in the project file, which causes us to ignore framework implicit defines.
Codecov Report
@@ Coverage Diff @@
## master #3579 +/- ##
=======================================
Coverage 68.27% 68.27%
=======================================
Files 735 735
Lines 36793 36793
Branches 2146 2146
=======================================
Hits 25119 25119
Misses 11250 11250
Partials 424 424
Continue to review full report at Codecov.
|
Pilchie
approved these changes
May 27, 2018
This was referenced May 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2720
The SDK automatically appends to DefineConstants with implicit constants after the project's definition of DefineConstant. When we attempt to read the value at the end of project file ("AfterContext") we think that user's value is set to include those and pick these up in the dialog which sets the property.
Instead move to reading the value at the point it was defined in the project file, which causes us to ignore framework implicit defines.