Fix formatting of wrapped CSS#12823
Merged
davidwengier merged 4 commits intodotnet:mainfrom Feb 24, 2026
Merged
Conversation
This should have got removed when `originalLineOffset` was added. It just gets in the way now
When fixing a bug, look for existing code that already attempts to handle the scenario before adding new code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DustinCampbell
approved these changes
Feb 24, 2026
|
|
||
| - Always build and test with `build.sh -test` before submitting PRs, without specifying a project or test filter | ||
| - Write clear, concise, and maintainable code | ||
| - When fixing a bug, look for existing code that already attempts to handle the scenario before adding new code. The bug is more likely in that existing logic than a missing feature. |
Member
Author
There was a problem hiding this comment.
Feels a bit like adding "write good code, not bad code" to me. I could totally see it taking this and running with it too, and deciding never to add new code. We'll see.
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a comment on https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2711658
When I fixed the bug around html attributes being spread across multiple lines, seems I was too strict on the conditions, for fear of introducing a bug, which introduced a bug (!) when there are multiple lines in a row that get expanded over multiple lines. So I just removed some of the guardrails.