Fix Watson crash in ToRazorTextDocumentIdentifier when DocumentUri is unparseable#13043
Merged
Fix Watson crash in ToRazorTextDocumentIdentifier when DocumentUri is unparseable#13043
Conversation
… unparseable Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2900155 DocumentUri.ParsedUri can be null when System.Uri cannot parse the URI string received from the client (e.g. unusual URI schemes in VS Code). RazorDocumentClosedEndpoint.GetRazorTextDocumentIdentifier called GetRequiredParsedUri() which threw InvalidOperationException via AssumeNotNull(), causing Watson crash 2900155. Changes: - ToRazorTextDocumentIdentifier now returns null when ParsedUri is null instead of throwing - RazorDocumentClosedEndpoint.HandleRequestAsync guards the DocumentRemoved call, skipping it when ParsedUri is null. This is safe because HtmlDocumentSynchronizer only tracks documents opened with valid URIs via TrySynchronizeAsync. - CohostSignatureHelpEndpoint now uses ToRazorTextDocumentIdentifier instead of hand-inlining the same logic with GetRequiredParsedUri
davidwengier
approved these changes
Apr 13, 2026
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2900155
DocumentUri.ParsedUri can be null when System.Uri cannot parse the URI string received from the client (e.g. unusual URI schemes in VS Code). RazorDocumentClosedEndpoint.GetRazorTextDocumentIdentifier called GetRequiredParsedUri() which threw InvalidOperationException via AssumeNotNull.
Changes: