Adding ReplaySubject perf improvements #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Supporting blog post with performance reports found here http://leecampbell.blogspot.com.au/2014/01/replaysubject-performance-improvements.html |
Contributor
Author
|
Thanks Kirk. Made the changes. |
Contributor
Author
|
@kirkshoop, I have added back the multiple disposals to the unit tests. I had inconsistently put them in some unit tests but not others. They are now in each of the ReplayOne, ReplayMany, ReplayAll and ReplayByTime infinite sequence tests. |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue https://rx.codeplex.com/workitem/35
Accompanying perf test console applications (https://github.com/LeeCampbell/RxPerfTests) shows performance is the same for Replay-By-Time and Replay-By-Time-and-Count.
However Replay-One, Replay-Many and Replay-All all benefit from the removal of the Scheduling and Time-stamped Queues. The removal of the extraneous code has the effect of less allocations being made for each subscription and OnNext call. This results in less Garbage Collections and a large increase in throughput.
The ReplaySubjectTests have been extended to ensure that while performance has been improved, that all existing functionality is maintained and remains consistent.