Skip to content

fix removing elements other than top #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix removing elements other than top #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions Rx.NET/Source/System.Reactive.Core/Reactive/Internal/PriorityQueue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,26 +33,23 @@ private bool IsHigherPriority(int left, int right)
return _items[left].CompareTo(_items[right]) < 0;
}

private void Percolate(int index)
private int Percolate(int index)
{
if (index >= _size || index < 0)
return;
return index;
var parent = (index - 1) / 2;
if (parent < 0 || parent == index)
return;
return index;

if (IsHigherPriority(index, parent))
{
var temp = _items[index];
_items[index] = _items[parent];
_items[parent] = temp;
Percolate(parent);
return Percolate(parent);
}
}

private void Heapify()
{
Heapify(0);
return index;
}

private void Heapify(int index)
Expand Down Expand Up @@ -91,7 +88,8 @@ private void RemoveAt(int index)
{
_items[index] = _items[--_size];
_items[_size] = default(IndexedItem);
Heapify();
if (Percolate(index) == index)
Heapify(index);
if (_size < _items.Length / 4)
{
var temp = _items;
Expand Down