Skip to content

4.x: LongCount() don't init to default zero #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2018
Merged

4.x: LongCount() don't init to default zero #677

merged 2 commits into from
Jun 28, 2018

Conversation

@akarnokd
Copy link
Collaborator

@akarnokd akarnokd commented Jun 27, 2018

There is no reason to initialize the _count to its default zero value.

@danielcweber
Copy link
Collaborator

danielcweber commented Jun 28, 2018

Will merge as soon as this WIP-bot becomes alive again....

@danielcweber danielcweber changed the title 4.x: LongCount() don't init to default zero WIP 4.x: LongCount() don't init to default zero Jun 28, 2018
@danielcweber danielcweber changed the title WIP 4.x: LongCount() don't init to default zero 4.x: LongCount() don't init to default zero Jun 28, 2018
@akarnokd
Copy link
Collaborator Author

akarnokd commented Jun 28, 2018

So GitHub doesn't even allow you to merge until the WIP status is okay?

@danielcweber
Copy link
Collaborator

danielcweber commented Jun 28, 2018

Nope. It's required and apparently the service doesn't answer.

@akarnokd akarnokd closed this Jun 28, 2018
@akarnokd akarnokd reopened this Jun 28, 2018
@danielcweber
Copy link
Collaborator

danielcweber commented Jun 28, 2018

According to this it's not down...

@akarnokd
Copy link
Collaborator Author

akarnokd commented Jun 28, 2018

Maybe it caches and reopening is not enough.

@danielcweber
Copy link
Collaborator

danielcweber commented Jun 28, 2018

Updating the branch didn't help either.

@akarnokd akarnokd changed the title 4.x: LongCount() don't init to default zero [WIP] 4.x: LongCount() don't init to default zero Jun 28, 2018
@akarnokd akarnokd changed the title [WIP] 4.x: LongCount() don't init to default zero 4.x: LongCount() don't init to default zero Jun 28, 2018
@akarnokd
Copy link
Collaborator Author

akarnokd commented Jun 28, 2018

I've renamed the PR to [WIP], then renamed it back and now the WIP service seems to be working again.

@danielcweber danielcweber merged commit 15866f2 into dotnet:master Jun 28, 2018
@akarnokd akarnokd deleted the LongCountCleanup branch June 28, 2018 15:21
@akarnokd akarnokd mentioned this pull request Jul 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielcweber danielcweber danielcweber approved these changes

+1 more reviewer

@quinmars quinmars quinmars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akarnokd @danielcweber @quinmars