Skip to content

4.x: Improve MaxBy cleanup/initialization #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 28, 2018
Merged

4.x: Improve MaxBy cleanup/initialization #679

merged 3 commits into from
Jun 28, 2018

Conversation

@akarnokd
Copy link
Collaborator

@akarnokd akarnokd commented Jun 27, 2018

  • Inline the selector and comparer callback fields into the sink.
  • Don't initialize fields to their defaults.
  • Clear the _list and _lastKey field on failure and completion.

@danielcweber danielcweber merged commit ad85f24 into dotnet:master Jun 28, 2018
@akarnokd akarnokd deleted the MaxByCleanup branch June 28, 2018 15:21
@akarnokd akarnokd mentioned this pull request Jul 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielcweber danielcweber danielcweber approved these changes

+1 more reviewer

@quinmars quinmars quinmars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akarnokd @danielcweber @quinmars