4.x: Fix AppendPrepend disposing the main source on ILongRunningSchedulers #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code, calling
base.Disposedisposed the_upstreamas well so when the_sourceis subscribed to, it is immediately disposed and may never run or items may never appear downstream due to a detached observer.The PR removes this call and is safe because:
_continueis aForwardOnCompleted, that callsbase.Dispose()anyway_continueis aSubscribeSafe, that is okay as_scheduledDisposableis just aBooleanDisposableand no other resources have to be disposed.The
AppendPrepend_SchedulerLongRunningverifies this scenario.