Mark fields as readonly as suggested by ReSharper. #728
Conversation
| { | ||
| #pragma warning disable IDE1006 // Naming Styles: 3rd party code is known to reflect for this specific field name | ||
| private static IQueryLanguageEx s_impl = QueryServices.GetQueryImpl<IQueryLanguageEx>(new QueryLanguageEx()); | ||
| private static readonly IQueryLanguageEx s_impl = QueryServices.GetQueryImpl<IQueryLanguageEx>(new QueryLanguageEx()); |
There was a problem hiding this comment.
This is a "hack" entry point. Remember why we couldn't inline the IQueryLanguage? Because RxSpy and others use this type of fields to inject their instrumentation.
There was a problem hiding this comment.
Alright, I though they did it through the PlatformEnlightenmentProvider. That should still be possible though.
We should try to get in touch with the RxSpy folks though soon.
There was a problem hiding this comment.
| { | ||
| #pragma warning disable IDE1006 // Naming Styles: 3rd party code is known to reflect for this specific field name | ||
| private static IQueryLanguage s_impl = QueryServices.GetQueryImpl<IQueryLanguage>(new QueryLanguage()); | ||
| private static readonly IQueryLanguage s_impl = QueryServices.GetQueryImpl<IQueryLanguage>(new QueryLanguage()); |
There was a problem hiding this comment.
This is a "hack" entry point. Remember why we couldn't inline the IQueryLanguage? Because RxSpy and others use this type of fields to inject their instrumentation.
There was a problem hiding this comment.
I'll revise that in a minute.
|
This has been revised. |
2 participants
No description provided.