Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VSSDK #74329

Closed
wants to merge 4 commits into from
Closed

Update VSSDK #74329

wants to merge 4 commits into from

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Jul 10, 2024 •
edited
Loading

Fixes #74156.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 10, 2024
@jjonescz jjonescz mentioned this pull request Jul 10, 2024
Merged
@build-analysis build-analysis bot mentioned this pull request Jul 10, 2024
Open
3 tasks
@arunchndr arunchndr requested review from tmat and genlu July 10, 2024 22:15
@jjonescz
Copy link
Member Author

Tests are failing with

System.TypeLoadException : Method 'NormalizeNewlines' in type 'Microsoft.VisualStudio.Text.Document.WhitespaceManager' from assembly 'Microsoft.VisualStudio.Platform.VSEditor, Version=17.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' does not have an implementation.

I guess that makes sense since I updated some VS packages and this might be running on older VS version?

@Cosifne
Copy link
Member

Cosifne commented Jul 15, 2024

Tests are failing with

System.TypeLoadException : Method 'NormalizeNewlines' in type 'Microsoft.VisualStudio.Text.Document.WhitespaceManager' from assembly 'Microsoft.VisualStudio.Platform.VSEditor, Version=17.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' does not have an implementation.

I guess that makes sense since I updated some VS packages and this might be running on older VS version?

Yeah but this would end up break the CI in main. Either we need to introducing a vs-deps branch or waiting the CI machine update

sharwell
sharwell reviewed Jul 16, 2024
View reviewed changes
src/VisualStudio/Core/Def/RoslynPackage.cs
var menuCommandService = (OleMenuCommandService)await GetServiceAsync(typeof(IMenuCommandService)).ConfigureAwait(true);
StackTraceExplorerCommandHandler.Initialize(menuCommandService, this);
var menuCommandService = (OleMenuCommandService?)await GetServiceAsync(typeof(IMenuCommandService)).ConfigureAwait(true);
StackTraceExplorerCommandHandler.Initialize(menuCommandService!, this);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
StackTraceExplorerCommandHandler.Initialize(menuCommandService!, this);
Assumes.Present(menuCommandService);
StackTraceExplorerCommandHandler.Initialize(menuCommandService, this);

@jjonescz jjonescz closed this Sep 6, 2024
@jjonescz jjonescz deleted the vssdk branch September 6, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell left review comments

@genlu genlu genlu approved these changes

@tmat tmat Awaiting requested review from tmat

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can only build Roslyn.sln a single time before building breaks (2)
5 participants
@jjonescz @Cosifne @genlu @sharwell @CyrusNajmabadi