Fix SmtpClient handling exceptions as timeouts#288
Merged
davidsh merged 1 commit intodotnet:masterfrom Nov 27, 2019
Merged
Conversation
Only non-async calls on SmtpClient can timeout. As the flag is not reset in the async path, it could already be set and SmtpClient would propagate any exception in the async path as a timeout
Member
What issue is this fixing? Can you share the issue number / link? |
Member
Author
|
To my knowledge, there isn't an issue opened about this, I just found the issue when reading the code. Steps to reproduce would look like:
|
davidsh
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug fix.
Only non-async calls on SmtpClient can timeout, but the flag is checked in the async path as well.
As the flag is not reset in the async path, it could already be set and SmtpClient would swallow any real exception and instead throw a timeout.
CC @dotnet/ncl