Module.FullyQualifiedName throws in single-file app

[vitek-karas]

On non-single file apps Module.FullyQualifiedName returns absolute path to the file of the module (which is basically always the assembly file). If the module is an in-memory module (so loaded from stream), it returns <Unknown> string.

In single-file if the module is one of the assemblies which are bundled it will throw from this property.

I think we should make it behave the same as it does for in-memory modules - so return <Unknown> for bundled assemblies.

The same applies to Module.Name (which is implemented by calling Module.FullyQualifiedName internally) - we need to test it.

Tagging subscribers to this area: @swaroop-sridhar, @agocke
See info in area-owners.md if you want to be subscribed.

[vitek-karas]

/cc @MichalStrehovsky @jkotas
Another API behavior question for single-file.

[jkotas]

behave the same as it does for in-memory modules - so return <Unkown> for bundled assemblies.

Agree.

[vitek-karas]

This issue sort of propagates to Assembly.GetFile/Assembly.GetFiles as well. On non-single-file app Assembly.GetFile returns the assembly file opened as a file stream. For in-memory assemblies the method throws IOException because it simply tries to open Module.FullyQualifiedName.

In single-file it now throws FileNotFoundException (that's this issue) so the exception type is different. This should get fixed once the original issue is fixed.

[vitek-karas]

Repro is part of the test app here: https://github.com/vitek-karas/single-file-feature-test

[jkotas]

In single-file it now throws FileNotFoundException (that's this issue) so the exception type is different. This should get fixed once the original issue is fixed.

It would be nice to explicitly throw in this case, and not depend what FileStream is going to throw when attempting to open <Unknown>. It can even succeed if you have a file called <Unknown> in the current directory.

[vitek-karas]

I created #40154 to track that as it's not single-file specific behavior.

[vitek-karas]

It seems that on Linux the API already behaves correctly (returns <Unknown>).