use PlatformSpecific attribute to supress platform specific Quic tests#82933
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsUsing ConditionalFact creates noise on platforms where given test would never run. The so we have less noise and possibly less entries in test database.
|
ManickaP
approved these changes
Mar 3, 2023
ManickaP
reviewed
Mar 3, 2023
stephentoub
reviewed
Mar 3, 2023
…formDetectionTests.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using ConditionalFact creates noise on platforms where given test would never run.
The
PlatformSpecificattributes allows to silently suppress tests that are not even candidatesso we have less noise and possibly less entries in test database.