Skip to content

Add SseFormatter #109832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 20, 2024
Merged

Add SseFormatter #109832

merged 13 commits into from
Nov 20, 2024

Conversation

@eiriktsarpalis
Copy link
Member

Fix #109294.

@eiriktsarpalis eiriktsarpalis self-assigned this Nov 14, 2024
@eiriktsarpalis eiriktsarpalis added this to the 10.0.0 milestone Nov 14, 2024
@ghost
Copy link

ghost commented Nov 14, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Nov 14, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

This was referenced Nov 14, 2024
Closed
Closed
Closed
Closed
This was referenced Nov 18, 2024
Open
Open
Open
@eiriktsarpalis eiriktsarpalis mentioned this pull request Nov 19, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Nov 20, 2024
Open
3 tasks
@eiriktsarpalis eiriktsarpalis merged commit b5750e6 into dotnet:main Nov 20, 2024
83 checks passed
@eiriktsarpalis eiriktsarpalis deleted the add-sse-writer branch November 20, 2024 09:57
@eiriktsarpalis eiriktsarpalis mentioned this pull request Nov 21, 2024
Closed
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@eiriktsarpalis @stephentoub @mikelle-rogers
Add SseFormatter (dotnet#109832)
f9d3dd3 
* Add SseFormatter.

* Update src/libraries/System.Net.ServerSentEvents/src/Resources/Strings.resx

Co-authored-by: Stephen Toub <stoub@microsoft.com>

* Document SseItem exceptions.

* Misc improvements and fixes.

* Reinstate ordering of parameters in serialization callback.

* Add SseItem<T>.ReconnectionInterval.

* Address feedback.

* Add parser validation for too small or too large retry intervals.

* Update src/libraries/System.Net.ServerSentEvents/src/System/Net/ServerSentEvents/SseFormatter.cs

Co-authored-by: Stephen Toub <stoub@microsoft.com>

* Handle CR line breaks.

* Simplify PooledByteBufferWriter.

---------

Co-authored-by: Stephen Toub <stoub@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bartonjs bartonjs bartonjs left review comments

@MihaZupan MihaZupan MihaZupan left review comments

@stephentoub stephentoub stephentoub approved these changes

+1 more reviewer

@gfoidl gfoidl gfoidl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@eiriktsarpalis eiriktsarpalis

Labels

area-System.Net new-api-needs-documentation

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add formatting support to System.Net.ServerSentEvents

5 participants

@eiriktsarpalis @stephentoub @gfoidl @bartonjs @MihaZupan