[browser] NativeAOT-LLVM support in browser-bench #110611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
maraf
requested review from
akoeplinger,
lewing and
pavelsavara
as code owners
|
Tagging subscribers to this area: @akoeplinger, @matouskozak |
pavelsavara
approved these changes
Dec 11, 2024
3 tasks
radekdoulik
reviewed
Dec 11, 2024
radekdoulik
approved these changes
Dec 11, 2024
This was referenced Dec 11, 2024
Closed
|
/ba-g Failure is unrelated timeout |
jkotas
reviewed
Dec 13, 2024
| <PublishTrimmed>true</PublishTrimmed> | ||
| <PublishDir>$(MSBuildThisFileDirectory)/bin/$(Configuration)/AppBundle</PublishDir> | ||
| <DebugType>none</DebugType> | ||
| <RestoreAdditionalProjectSources>$(RestoreAdditionalProjectSources);https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-experimental/nuget/v3/index.json</RestoreAdditionalProjectSources> |
There was a problem hiding this comment.
Can the reference to the dotnet-experimental feed be in the runtimelab branch only?
I understand that this is under a condition currently, but it makes auditing of dotnet/runtime more complicated and introduces risk of accidental dependencies of dotnet/rutime on runtimelab.
There was a problem hiding this comment.
It is used only in the "sample" project, but I can remove the reference from sources and @radekdoulik can configure it when running the bench on the infra
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build browser-bench for NativeAOT-LLVM with
-p:UsingNativeAOT=true