Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 25, 2025

Backport of #119031 to release/10.0

/cc @thaystg

Customer Impact

  • Customer reported
  • Found internally

While implementing the Android CoreCLR debugger, we found an issue where we would create a module using garbage as the address of the module. This happened likely because of the change we made in #118414 where the following code can contain a trash value:

pModule = m_modules.GetBase(VmPtrToCookie(vmModule));

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

Manually tested when debugging on android.

Risk

Low, only initializing an empty field.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please fill in the template and get a code review. we can merge when ready

@jeffschwMSFT jeffschwMSFT added this to the 10.0.0 milestone Aug 26, 2025
Copy link
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

@steveisok steveisok self-requested a review August 29, 2025 18:24
@thaystg
Copy link
Member

thaystg commented Aug 29, 2025

approved. please fill in the template and get a code review. we can merge when ready

Done, thanks!

@jeffschwMSFT jeffschwMSFT merged commit a1556fc into release/10.0 Sep 2, 2025
103 checks passed
@jkotas jkotas deleted the backport/pr-119031-to-release/10.0 branch September 8, 2025 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants