[release/10.0] Consider all MemberInfo references for IsCollectible (#119869) #119911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnet#119869) Use ReflectedType instead DeclaringType since ReflectedType can be colletible even when DeclaringType is not. These fixes support typical IsCollectible use case where the property is used to determine whether or how the reflection objects can be cached. Fix dotnet#119697
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the IsCollectible property implementation for reflection MemberInfo objects to correctly consider all references when determining collectibility. The change addresses an issue where certain shared generic methods and specialized reflected types were incorrectly returning false for IsCollectible, preventing proper unloading of collectible assemblies.
- Changes the IsCollectible property implementation to use ReflectedTypeInternal instead of the declaring type
- Updates test methods to be more comprehensive by testing all members instead of individual named members
- Adds special handling for RuntimeMethodInfo to check both ReflectedTypeInternal and the method handle's collectibility
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| RuntimePropertyInfo.cs | Updates IsCollectible to use ReflectedTypeInternal instead of m_declaringType |
| RuntimeMethodInfo.CoreCLR.cs | Implements more comprehensive IsCollectible logic checking both ReflectedTypeInternal and method handle |
| RuntimeFieldInfo.cs | Updates IsCollectible to use ReflectedTypeInternal instead of m_declaringType |
| RuntimeEventInfo.cs | Updates IsCollectible to use ReflectedTypeInternal instead of m_declaringType |
| RuntimeConstructorInfo.CoreCLR.cs | Updates IsCollectible to use ReflectedTypeInternal instead of m_declaringType |
| IsCollectibleTests.cs | Refactors tests from Theory to Fact methods and tests all members comprehensively |
|
Tagging subscribers to this area: @dotnet/area-system-reflection |
jkoritzinsky
approved these changes
Sep 19, 2025
agocke
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119869 to release/10.0
Customer Impact
Unable to unload collectible assemblies after calling framework APIs that cache certain reflection MemberInfos. Fix #119697.
MemberInfo.IsCollectible is frequently used to determine whether the reflection objects can be cached unconditionally. It was returning wrong result (false instead of true) for shared generic methods and more specialized reflected types, that in turn caused the MemberInfo to be cached unconditionally and prevented unloading of collectible assemblies that it referenced.
Regression
Testing
New tests added to exercise the fixed behavior
Risk
Low