Failfast from async inst+unbox thunks #121812
Merged
+81
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and block tests on ActiveIssue. FailFast is better than memory corruptions.
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
Copilot finished reviewing on behalf of
MichalStrehovsky
November 19, 2025 18:53
jkotas
approved these changes
Nov 19, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds failfast behavior for async instantiating and unboxing thunks in NativeAOT to prevent memory corruption, along with comprehensive test coverage for the affected scenarios.
- Adds failfast calls in three thunk generation paths when async methods are detected, preventing memory corruption until proper async support is implemented
- Marks existing and new tests with ActiveIssue attributes to skip them on NativeAOT until issue #121781 is resolved
- Expands test coverage to include default interface methods with async implementations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/CompilerTypeSystemContext.InterfaceThunks.cs | Adds failfast for async calls in instantiating stubs to prevent memory corruption |
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/CompilerTypeSystemContext.BoxedTypes.cs | Adds failfast for async calls in two unboxing stub paths to prevent memory corruption |
| src/tests/async/inst-unbox-thunks/inst-unbox-thunks.cs | Adds ActiveIssue attributes to existing tests and new test cases for async default interface methods |
| src/tests/async/inst-unbox-thunks/inst-unbox-thunks.csproj | Adds TestLibrary project reference needed for IsNativeAot check in ActiveIssue attributes |
jtschuster
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and block tests on ActiveIssue.
FailFast is better than memory corruptions.
Cc @dotnet/ilc-contrib