Microsoft.Extensions.Configuration: enabling FileExtensions/Ini #33844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft.Extensions.Configuration.FileExtensions Microsoft.Extensions.Configuration.Ini
ericstj
approved these changes
Mar 20, 2020
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\Config\test\Microsoft.Extensions.Configuration.Tests.csproj" /> | ||
| <Compile Include="$(LibrariesProjectRoot)Microsoft.Extensions.Configuration\tests\ConfigurationRootTest.cs"> |
There was a problem hiding this comment.
nit: might make sense to move to common
There was a problem hiding this comment.
- Future PR: Code cleanup move shared files between Configuration projects to Common folder
|
Looks like testing was ongoing when the build was cancelled. There were no test failures. |
maryamariyan
added
area-Extensions-Configuration
and removed
area-Microsoft.Extensions
labels
11 tasks
1 task
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft.Extensions.Configuration.FileExtensions
Microsoft.Extensions.Configuration.Ini