[Release/5.0-preview6] Expose ReferenceResolver and rename ReferenceHandling to ReferenceHandler #37296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dler (dotnet#36829) * Expose ReferenceResolver and rename ReferenceHandling to ReferenceHandler * Address some feedback * Address feedback * Clean-up code * Change messages in string.resx * Add test for a badly implemented resolver * Address feedback.
Collaborator
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
leecow
added
Servicing-approved
Member
|
@ajcvickers this will impact EF as I see you just added consumption of this API in dotnet/efcore#20827. Be on the lookout for the ingestion PR and fix up the test to use the new API. @jozkee can you help them with this? |
Contributor
|
Yep, heard this in tactics. It will just be a simple test update.
|
layomia
approved these changes
Jun 4, 2020
jozkee
added a commit
to dotnet/efcore
that referenced
this pull request
Jun 4, 2020
Follow up to dotnet/runtime#37296 (comment) The property and the type ReferenceHandling were recently renamed to Referencehandler on dotnet/runtime#36829 Above PR was also ported to dotnet/runtime preview6 branch under dotnet/runtime#37296 therefore once this is into master, it should be ported to release/5.0-preview6 branch as well.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Port of #36829 to preview6.
Description from original PR (click to view)
Address the following as it was detailed in #30820 (comment):
ReferenceHandlingto resemble a class.ReferenceResolverclass.ReferenceHandler<T> where T : ReferenceResolverto allow users to safely provide their own resolver implementation that will be instantiated on each call to (De)Serialize.ReferenceHandlerabstract so if you override it you can opt-in for using a persistent resolver.This PR effectively closes #30820 as no more changes would be pending to address.
Customer Impact
This allow users to try out the latest shape of the
ReferenceHandlerAPI and give preview customers an early notice that their code using the feature needs to be updated since it is a breaking change between previews.Risk
Code has been tested but it is a breaking change between previews.