Skip to content

Normalize directory separator of paths in FileSpec #40699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Normalize directory separator of paths in FileSpec #40699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f3596e
Normalize directory separator
Aug 12, 2020
64ca2e6
Normalize dir separator on relative paths in FileEntry
Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/installer/managed/Microsoft.NET.HostModel/Bundle/FileEntry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class FileEntry
public FileEntry(FileType fileType, string relativePath, long offset, long size)
{
Type = fileType;
RelativePath = relativePath.Replace(Path.DirectorySeparatorChar, DirectorySeparatorChar);
RelativePath = relativePath.Replace('\\', DirectorySeparatorChar);
Copy link
Member

@agocke agocke Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break if this is a unix path that actually has a \ in the file name?

Copy link
Contributor Author

@mateoatr mateoatr Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would, but I'm not sure what the experience should be for these cases... dotnet new console -o 'a\b\c' or having a C# file named 'x\y\z.cs' and then doing dotnet build won't work either.

Copy link
Member

@agocke agocke Aug 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right -- it looks like the rest of the tooling doesn't like that either. In that case, I'm fine with this fix. The scenario we'd be breaking really isn't supported today.

Offset = offset;
Size = size;
}
Expand Down