Skip to content

[release/7.0-staging][wasm] runtime: Fix creating the stack trace for a ManagedError #89905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[release/7.0-staging][wasm] runtime: Fix creating the stack trace for a ManagedError #89905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5266d23
[wasm] runtime: Fix creating the stack trace for a ManagedError
radical Aug 3, 2023
0360142
[wasm] Bump chrome used for testing to 115.0.5790.171
radical Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions eng/testing/ProvisioningVersions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@
the same snapshot might not be available in both of them.
-->
<PropertyGroup Condition="'$(BrowserHost)' != 'windows'">
<ChromiumRevision>972765</ChromiumRevision>
<ChromiumUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/$(ChromiumRevision)/chrome-linux.zip</ChromiumUrl>
<ChromeDriverUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/$(ChromiumRevision)/chromedriver_linux64.zip</ChromeDriverUrl>
<ChromiumRevision>1148114</ChromiumRevision>
<!-- 115.0.5790.170 -->
<ChromiumUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1148123/chrome-linux.zip</ChromiumUrl>
<ChromeDriverUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1148123/chromedriver_linux64.zip</ChromeDriverUrl>
<ChromiumDirName>chrome-linux</ChromiumDirName>
<ChromeDriverDirName>chromedriver_linux64</ChromeDriverDirName>
<ChromiumBinaryName>chrome</ChromiumBinaryName>
Expand All @@ -21,9 +22,10 @@
</PropertyGroup>

<PropertyGroup Condition="'$(BrowserHost)' == 'windows'">
<ChromiumRevision>972766</ChromiumRevision>
<ChromiumUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/$(ChromiumRevision)/chrome-win.zip</ChromiumUrl>
<ChromeDriverUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/$(ChromiumRevision)/chromedriver_win32.zip</ChromeDriverUrl>
<ChromiumRevision>1148114</ChromiumRevision>
<!-- 115.0.5790.170 -->
<ChromiumUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1148119/chrome-win.zip</ChromiumUrl>
<ChromeDriverUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1148119/chromedriver_win32.zip</ChromeDriverUrl>
<ChromiumDirName>chrome-win</ChromiumDirName>
<ChromeDriverDirName>chromedriver_win32</ChromeDriverDirName>
<ChromiumBinaryName>chrome.exe</ChromiumBinaryName>
Expand Down
5 changes: 4 additions & 1 deletion src/mono/wasm/runtime/marshal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,10 @@ export class ManagedError extends Error implements IDisposable {

getSuperStack() {
if (this.superStack) {
return this.superStack.value;
if (this.superStack.value !== undefined)
return this.superStack.value;
if (this.superStack.get !== undefined)
return this.superStack.get.call(this);
}
return super.stack; // this works on FF
}
Expand Down