Fix issues in marshallers #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a pretty obvious bug in reverse interface marshalling * Fixes error case in `SafeHandle` marshaller. The existing code was trying to generate throwing code in a wrong spot, leaving IL that is difficult to compute stack height for with our naive algorithm. `MissingMethodException` is the CLR-compatible behavior.
MichalStrehovsky
added
the
area-NativeAOT-coreclr
jkotas
reviewed
Oct 5, 2020
| new TypeDesc[] { | ||
| Context.GetWellKnownType(WellKnownType.String) | ||
| }); | ||
| MethodDesc exceptionCtor = InteropTypes.GetMissingMemberException(Context).GetKnownMethod(".ctor", ctorSignature); |
Member
There was a problem hiding this comment.
InteropTypes.GetMissingMemberException is no longer used. Delete it?
jkotas
reviewed
Oct 5, 2020
| if (ctor == null || ((MetadataType)ManagedType).IsAbstract) | ||
| { | ||
| #if READYTORUN | ||
| // Let the runtime generate the proper MissingMemberException for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeHandlemarshaller. The existing code was trying to generate throwing code in a wrong spot, leaving IL that is difficult to compute stack height for with our naive algorithm.MissingMethodExceptionis the CLR-compatible behavior (see SafeCertContextHandle is missing a default constructor runtime#43016).