Skip to content

Change signing expansion #3204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

Change signing expansion #3204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions eng/pipelines/common/global-build-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ parameters:
condition: true
useContinueOnErrorDuringBuild: false
shouldContinueOnError: false
enableSigning: ''
isOfficialBuild: false
runtimeFlavor: 'coreclr'
runtimeVariant: ''
Expand Down Expand Up @@ -52,8 +53,8 @@ jobs:
timeoutInMinutes: ${{ parameters.timeoutInMinutes }}
enablePublishTestResults: ${{ parameters.enablePublishTestResults }}
testResultsFormat: ${{ parameters.testResultsFormat }}
enableMicrobuild: ${{ parameters.isOfficialBuild }}
enableMicrobuildForMacAndLinux: ${{ parameters.isOfficialBuild }}
enableMicrobuild: ${{ coalesce(parameters.enableSigning, parameters.isOfficialBuild) }}
enableMicrobuildForMacAndLinux: ${{ coalesce(parameters.enableSigning, parameters.isOfficialBuild) }}
templateContext: ${{ parameters.templateContext }}

artifacts:
Expand Down
7 changes: 6 additions & 1 deletion eng/pipelines/official/jobs/prepare-signed-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,13 @@ jobs:
- ${{ if eq(parameters.isOfficialBuild, true) }}:
- name: '_SignType'
value: $[ coalesce(variables.OfficialSignType, 'real') ]
- name: _SignArgs
value: -sign
- ${{ else }}:
- name: '_SignType'
value: $[ coalesce(variables.OfficialSignType, 'test') ]
- name: _SignArgs
value: ''

templateContext:
inputs:
Expand All @@ -48,7 +52,8 @@ jobs:

steps:
- script: >-
build.cmd -restore -sign -publish -ci -configuration Release
build.cmd -restore -publish -ci -configuration Release
$(_SignArgs)
/p:RestoreToolsetOnly=true
/p:PublishRidAgnosticPackagesFromPlatform=${{ parameters.PublishRidAgnosticPackagesFromPlatform }}
/p:DownloadDirectory=$(Build.SourcesDirectory)\artifacts\PackageDownload\
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/runtimelab-official.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ extends:
jobParameters:
templatePath: 'templates-official'
timeoutInMinutes: 300
enableSigning: false
isOfficialBuild: true
testGroup: innerloop
buildArgs: -s clr.aot+libs -c $(_BuildConfig)
Expand Down