Skip to content

Conversation

@vlada-shubina
Copy link
Member

Following the move of source code to dotnet/sdk, removed it from this repo and updated the docs
Dev documentation became outdated, and will be updated in #408

@vlada-shubina vlada-shubina requested a review from a team April 19, 2023 18:14
Copy link

@donJoseLuis donJoseLuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single minor comment

This project consists of APIs and MSBuild Tasks for generating and testing an [OCI Container](https://opencontainers.org/) from a .NET project.

A basic start with the library in an existing project:
A basic start with tooling

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider rephrasing 'A basic start with tooling' to a more intuitive sentence.

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few grammar suggestions on the readme. Should we move the DevGuide over to the SDK instead?

vlada-shubina and others added 2 commits April 26, 2023 16:50
Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>
@vlada-shubina
Copy link
Member Author

Left a few grammar suggestions on the readme. Should we move the DevGuide over to the SDK instead?

Since this repo will be likely an entry point, I would rather keep it here. I will link dotnet/sdk to dev guide once #426 is merged.

@baronfel baronfel enabled auto-merge April 28, 2023 15:29
@baronfel baronfel disabled auto-merge April 28, 2023 15:30
@baronfel
Copy link
Member

Merging without build because this removes the build :D

@baronfel baronfel merged commit 8f00d24 into dotnet:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants