ResolvePackageFileConflicts throwing when referencing System.Diagnostics.DiagnosticSource by assembly path

[rynowak]

This is new failure that just started happening in some Razor tests for our MSBuild functionality. This started failing for us 2.2.0-preview1-007927 - this was working before in 2.2.0-preview1-007866.

I've attached a repro project, which is doing some esoteric things because this is part of our tests for our MSBuild targets 😆. I think the probably might not be anything wierd that we're doing though.

The project file looks like this:

<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup Condition="'$(BinariesRoot)'==''">
    <!-- In test scenarios $(BinariesRoot) is defined in a generated Directory.Build.props file -->
    <ProjectReference Include="..\..\Microsoft.AspNetCore.Razor.Test.MvcShim\Microsoft.AspNetCore.Razor.Test.MvcShim.csproj"/>
    <ProjectReference Include="..\..\..\src\Microsoft.AspNetCore.Razor.Runtime\Microsoft.AspNetCore.Razor.Runtime.csproj"/>
  </ItemGroup>

  <ItemGroup Condition="'$(BinariesRoot)'!=''">
    <Reference Include="$(BinariesRoot)\System.Diagnostics.DiagnosticSource.dll"/>
    <Reference Include="$(BinariesRoot)\Microsoft.AspNetCore.Html.Abstractions.dll"/>
    <Reference Include="$(BinariesRoot)\Microsoft.AspNetCore.Razor.dll"/>
    <Reference Include="$(BinariesRoot)\Microsoft.AspNetCore.Razor.Runtime.dll"/>
    <Reference Include="$(BinariesRoot)\Microsoft.AspNetCore.Razor.Test.MvcShim.dll"/>
  </ItemGroup>
</Project>

Removing <Reference Include="$(BinariesRoot)\System.Diagnostics.DiagnosticSource.dll"/> seems to fix it.

Microsoft (R) Build Engine version 15.6.22.57775 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restoring packages for C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj...
  Generating MSBuild file C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\obj\SimpleMvc.csproj.nuget.g.props.
  Generating MSBuild file C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\obj\SimpleMvc.csproj.nuget.g.targets.
  Restore completed in 273.82 ms for C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj.
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018: The "ResolvePackageFileConflicts" task failed unexpectedly. [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018: System.ArgumentNullException: Value cannot be null. [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018: Parameter name: key [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018:    at System.Collections.Generic.Dictionary`2.FindEntry(TKey key) [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018:    at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value) [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ConflictResolution.PackageOverrideResolver`1.Resolve(TConflictItem item1, TConflictItem item2) [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ConflictResolution.ConflictResolver`1.ResolveConflict(TConflictItem item1, TConflictItem item2) [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ConflictResolution.ConflictResolver`1.ResolveConflicts(IEnumerable`1 conflictItems, Func`2 getItemKey, Action`1 foundConflict, Boolean commitWinner, Action`1 unresolvedConflict) [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ConflictResolution.ResolvePackageFileConflicts.ExecuteCore()[C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute() [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() in E:\A\_work\24\s\src\Build\BackEnd\TaskExecutionHost\TaskExecutionHost.cs:line 631 [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]
C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\Sdks\Microsoft.NET.Sdk\build\Microsoft.NET.ConflictResolution.targets(59,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__25.MoveNext() in E:\A\_work\24\s\src\Build\BackEnd\Components\RequestBuilder\TaskBuilder.cs:line 787 [C:\Users\rynowak\AppData\Local\Temp\Razor\sbp0bspc.b03\SimpleMvc\SimpleMvc.csproj]

.NET Command Line Tools (2.2.0-preview1-007927)

Product Information:
 Version:            2.2.0-preview1-007927
 Commit SHA-1 hash:  a212d5a017

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.15063
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Users\rynowak\.dotnet\x64\sdk\2.2.0-preview1-007927\

Microsoft .NET Core Shared Framework Host

  Version  : 2.1.0-preview1-26110-02
  Build    : 77152705cd56e7d89f52585959ec3559d91084c4

Repro.zip

[jkotalik]

I am also getting this error, however it was through targeting net461 and trying to publish the app:

The "ResolvePackageFileConflicts" task failed unexpectedly.
System.ArgumentNullException: Value cannot be null.
Parameter name: key
   at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
   at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
   at Microsoft.NET.Build.Tasks.ConflictResolution.PackageOverrideResolver`1.Resolve(TConflictItem item1, TConflictItem item2)
   at Microsoft.NET.Build.Tasks.ConflictResolution.ConflictResolver`1.ResolveConflict(TConflictItem item1, TConflictItem item2)
   at Microsoft.NET.Build.Tasks.ConflictResolution.ConflictResolver`1.ResolveConflicts(IEnumerable`1 conflictItems, Func`2 getItemKey, Action`1 foundConflict, Boolean commitWinner, Action`1 unresolvedConflict)
   at Microsoft.NET.Build.Tasks.ConflictResolution.ResolvePackageFileConflicts.ExecuteCore()
   at Microsoft.NET.Build.Tasks.TaskBase.Execute()
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()	NativeIISSample	

csproj:

<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
    <RuntimeIdentifiers>win-x64</RuntimeIdentifiers>
  </PropertyGroup>
  <ItemGroup>
    <ProjectReference Include="..\..\src\Microsoft.AspNetCore.Server.IISIntegration\Microsoft.AspNetCore.Server.IISIntegration.csproj" />
  </ItemGroup>

  <ItemGroup Condition="'$(OS)' == 'Windows_NT'">
    <!-- x86 -->
    <None Include="..\..\src\RequestHandler\bin\$(Configuration)\Win32\aspnetcorerh.dll" CopyToOutputDirectory="PreserveNewest" Visible="false" Link="x86\aspnetcorerh.dll" />
    <None Include="..\..\src\AspNetCore\bin\$(Configuration)\Win32\aspnetcore.dll" CopyToOutputDirectory="PreserveNewest" Visible="false" Link="x86\aspnetcore.dll" />
    <!-- x64 -->
    <None Include="..\..\src\RequestHandler\bin\$(Configuration)\x64\aspnetcorerh.dll" CopyToOutputDirectory="PreserveNewest" Visible="false" Link="x64\aspnetcorerh.dll" />
    <None Include="..\..\src\AspNetCore\bin\$(Configuration)\x64\aspnetcore.dll" CopyToOutputDirectory="PreserveNewest" Visible="false" Link="x64\aspnetcore.dll" />
  </ItemGroup>
  
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.Hosting" Version="$(MicrosoftAspNetCoreHostingPackageVersion)" />
  </ItemGroup>

</Project>

[ericstj]

/cc @eerhardt
I just hit the same thing with a very simple project:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net462</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="System.Memory" Version="4.5.0-preview1-26216-02" />
  </ItemGroup>

</Project>

@livarcocc you need to raise priority of this. I'm going to see if I can see what's going on and propose a fix.

[ericstj]

As a workaround I was able to set DisableDefaultPackageConflictOverrides=true.

[ericstj]

This is happening whenever there is a conflict between a package assembly and a non-package assembly. In the .NET framework case it was due to a conflict between

sdk/src/Tasks/Microsoft.NET.Build.Extensions.Tasks/msbuildExtensions/Microsoft/Microsoft.NET.Build.Extensions/Microsoft.NET.Build.Extensions.NETFramework.targets

Lines 122 to 130 in cfe8ff3

	<Reference Include="%(_NETStandardLibraryNETFrameworkLib.FileName)">
	<HintPath>%(_NETStandardLibraryNETFrameworkLib.Identity)</HintPath>
	<Private>false</Private>
	<ExternallyResolved>$(MarkNETFrameworkExtensionAssembliesAsExternallyResolved)</ExternallyResolved>
	</Reference>
	<ReferenceCopyLocalPaths Include="@(_NETStandardLibraryNETFrameworkLib)" Condition="'%(FileName)' != 'netfx.force.conflicts'">
	<Private>false</Private>
	</ReferenceCopyLocalPaths>

and the platform manifest (as determined by the FileList from the targeting pack).

At a minimum we should fix the null check. We may also want to fix perf here by applying a package ID to the files brought in from the Microsoft.NET.Build.Extensions.NETFramework.targets, otherwise I believe we'll end up falling back to reading the file metadata.

[livarcocc]

@dsplaisted can you please take a look?

[ericstj]

Interesting, the plot thickens. In my case I also got the wrong PackageId set for platform items because we passed a filename to NuGetUtils.GetPackageIdFromSourcePath, it ended up using CurrentDir/ProjectDir and found a nuspec in my tree, so it ended up assigning a packageId incorrectly to platform items.

[ericstj]

I put up a PR to fix this.