Duplicated dependency via project reference and nuget leads to GenerateDepsFile crash

[nguerrera]

Repro steps

• Have a PackageReference to Foo.nupkg
• Also have a ProjectReference to Foo.csproj producing the same dll as nupkg

Expected behavior

• Project reference wins and build succeeds

Actual behavior

• Package reference wins for compilation input, GenerateDepsFile throws and aborts build.

[nguerrera]

Workaround:

  <Target Name="WorkAroundPackageAndProjectReferenceConflict" 
                BeforeTargets="ResolveLockFileReferences">
    <ItemGroup>
       <ResolvedCompileFileDefinitions 
           Remove="@(ResolvedCompileFileDefinitions)" 
           Condition="'%(ResolvedCompileFileDefinitions.Filename)' == 'Foo'" />
    </ItemGroup>
  </Target>