The `--tl` option is not displayed when `dotnet build|clean|tests -h` is invoked

[gasparnagy]

Describe the bug

The --tl option is not displayed when dotnet build|clean|tests -h is invoked.

I am happy to help to fix this, but I need some guidance.

I did a bit of an analysis and found that the -tl option is detected by the test command using the TerminalLoggerDetector class that gets it from the parseResult.UnmatchedTokens.

I think if I would add a common command line option, like for example verbosity is done, the processing would remove it from the unmatched tokens and the detector would not work.

To Reproduce

Invoke dotnet build -h, dotnet clean -h, dotnet test -h.

Exceptions (if any)

It displays the --tl option (as described in the documentation.

Further technical details

details of dotnet --info

.NET SDK: Version: 10.0.100-rc.1.25451.107 Commit: 2db1f5ee2b Workload version: 10.0.100-manifests.0e2d47c4 MSBuild version: 17.15.0-preview-25451-107+2db1f5ee2

Runtime Environment:
OS Name: Windows
OS Version: 10.0.26100
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\10.0.100-rc.1.25451.107\

.NET workloads installed:
There are no installed workloads to display.
Configured to use workload sets when installing new manifests.
No workload sets are installed. Run "dotnet workload restore" to install a workload set.

Host:
Version: 10.0.0-rc.1.25451.107
Architecture: x64
Commit: 2db1f5ee2b

.NET SDKs installed:
6.0.428 [C:\Program Files\dotnet\sdk]
7.0.410 [C:\Program Files\dotnet\sdk]
8.0.414 [C:\Program Files\dotnet\sdk]
9.0.305 [C:\Program Files\dotnet\sdk]
10.0.100-rc.1.25451.107 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.36 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.20 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 10.0.0-rc.1.25451.107 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.36 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.20 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 10.0.0-rc.1.25451.107 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 6.0.36 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.20 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 9.0.9 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 10.0.0-rc.1.25451.107 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
x86 [C:\Program Files (x86)\dotnet]
registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
DOTNET_SUGGEST_SCRIPT_VERSION [1.0.2]

global.json file:
Not found

Learn more:
https://aka.ms/dotnet/info

Download .NET:
https://aka.ms/dotnet/download

[gasparnagy]

This is related to dotnet/docs#48872

[baronfel]

I think @MichalPavlik is working on this as a prerequisite for fixing some dotnet test related bug that block the rollout of MSBuild Server, so I wouldn't suggest spending your own time on it at this time.

As a general rule, the commands you mention accept any MSBuild option in addition to their own dotnet CLI options. We don't model the whole of the MSBuild CLI grammar because it's too big of a task - instead we take just the pieces we need. We haven't done --tl until now in part because the dotnet CLI didn't want to be in the business of determining that default, but other work makes that unfortunately necessary.

[gasparnagy]

I think @MichalPavlik is working on this as a prerequisite for fixing some dotnet test related bug that block the rollout of MSBuild Server, so I wouldn't suggest spending your own time on it at this time.

All good. Thx for the info. Shall we keep this issue open as a reminder to check?

@MichalPavlik if you need help, just let me know.

[jjonescz]

Having the -tl option recognized by the dotnet CLI would be good for dotnet run file.cs too because currently that falls back to project-based dotnet run if there are unrecognized options, and being able to dotnet run file.cs -tl:something would be useful (I admit I tried to run that several times because I always forget that's not supported).