Support filtering satellite assemblies from publish via SatelliteResourceLanguages property #2040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urceLanguages property Fixes dotnet#774
dsplaisted
force-pushed
the
774-filter-published-satellite-assemblies
branch
from
e5c6111 to
4213687
Compare
dsplaisted
force-pushed
the
774-filter-published-satellite-assemblies
branch
from
4213687 to
121ee18
Compare
dsplaisted
requested review from
johnbeisner,
livarcocc,
nguerrera,
peterhuene,
tannergooding and
wli3
nguerrera
reviewed
Mar 14, 2018
| Condition="'%(ResolvedAssembliesToPublish.AssetType)' == 'resources'" /> | ||
| </ItemGroup> | ||
|
|
||
| <JoinItems Left="@(PublishSatelliteResources)" LeftKey="Culture" LeftMetadata="*" |
Contributor
There was a problem hiding this comment.
The one remaining JoinItems still shows up as relatively slow. We probably want to see about speeding it up. Given that this only kicks in with SatelliteResourceLanguages set, it is probably OK.
nguerrera
approved these changes
Mar 14, 2018
JL03-Yue
pushed a commit
that referenced
this pull request
Mar 19, 2024
…130.7 (#2040) [main] Update dependencies from dotnet/arcade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #774
Thanks to @wli3 for pairing on this.