Catch dotnet watch task cancellation after CTRL+C
#23316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
TanayParikh
changed the title
CTRL+CCTRL+C
TanayParikh
added
the
Area-AspNetCore
TanayParikh
added a commit
that referenced
this pull request
Jan 12, 2022
(cherry picked from commit abaa783)
TanayParikh
added a commit
that referenced
this pull request
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty flaky issue, but after this change I've been unable to repro the task cancellation.
View with
w=1(no whitespace changes) to simplify review. I just moved the try/catch block to the method, rather than have it at the call location, as we do not await theasyncfunction at the call location.Fixes: dotnet/aspnetcore#37113
Fixes: dotnet/aspnetcore#37047