Skip to content

Conversation

@edvilme
Copy link
Contributor

@edvilme edvilme commented Apr 11, 2025

Refactors code logic introduced in #47961 to use CommonArguments.PackageIdentityArgument logic introduced in #48085

@ghost ghost added the untriaged Request triage from a team member label Apr 11, 2025
@ghost
Copy link

ghost commented Apr 11, 2025

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
@ghost
Copy link

ghost commented Apr 11, 2025

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@edvilme edvilme force-pushed the edvilme-package-at-version branch from 303c0cd to 305ea13 Compare April 14, 2025 18:28
@edvilme edvilme marked this pull request as ready for review April 14, 2025 18:59
@edvilme edvilme requested review from a team and Copilot April 14, 2025 18:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • test/dotnet.Tests/CompletionTests/snapshots/bash/DotnetCliSnapshotTests.VerifyCompletions.verified.sh: Language not supported
  • test/dotnet.Tests/CompletionTests/snapshots/pwsh/DotnetCliSnapshotTests.VerifyCompletions.verified.ps1: Language not supported
  • test/dotnet.Tests/CompletionTests/snapshots/zsh/DotnetCliSnapshotTests.VerifyCompletions.verified.zsh: Language not supported

@edvilme edvilme requested a review from baronfel April 14, 2025 19:02
@edvilme edvilme enabled auto-merge (squash) April 21, 2025 20:22
@edvilme edvilme merged commit d75e58a into dotnet:main Apr 22, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants