Fix dotnet test detection for dlls #51309
Merged
+28
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51249
Fixes #50923
Before the fix, the added test will fail:
In case of failure, StdErr will also contain:
This fixes a regression from #50926
Description
This fixes a regression in .NET 10 GA for parsing
dotnet test
command for VSTest and deciding whether we should forward to MSBuild and VSTest. If an MSBuild distributed logger is used where the value ends with.dll
, we incorrectly considered that the given dll is an assembly we want to run tests for, and we offloaded the work to VSTest instead of MSBuildCustomer impact
Issue was reported by customer in #51249. There is some CI scenario that runs the following:
The
-dl
part that ended with.dll
was causing issues due to incorrect parsing.Regression
Yes
Testing
Added automated test.
Risk
Low