Skip to content

Fix dotnet test detection for dlls #51309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

Fix dotnet test detection for dlls #51309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
098b4f0
Fix dotnet test detection for dlls
Youssef1313 Oct 16, 2025
3b30576
Add test
Youssef1313 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/Cli/dotnet/Commands/Test/VSTest/TestCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public static int Run(ParseResult parseResult)

// Fix for https://github.com/Microsoft/vstest/issues/1453
// Run dll/exe directly using the VSTestForwardingApp
if (ContainsBuiltTestSources(args))
if (ContainsBuiltTestSources(parseResult))
{
return ForwardToVSTestConsole(parseResult, args, settings, testSessionCorrelationId);
}
Expand Down Expand Up @@ -295,18 +295,14 @@ internal static int RunArtifactPostProcessingIfNeeded(string testSessionCorrelat
}
}

private static bool ContainsBuiltTestSources(string[] args)
private static bool ContainsBuiltTestSources(ParseResult parseResult)
{
for (int i = 0; i < args.Length; i++)
for (int i = 0; i < parseResult.UnmatchedTokens.Count; i++)
{
string arg = args[i];
if (arg.EndsWith(".dll", StringComparison.OrdinalIgnoreCase) || arg.EndsWith(".exe", StringComparison.OrdinalIgnoreCase))
string arg = parseResult.UnmatchedTokens[i];
if (!arg.StartsWith("-") &&
(arg.EndsWith(".dll", StringComparison.OrdinalIgnoreCase) || arg.EndsWith(".exe", StringComparison.OrdinalIgnoreCase)))
{
var previousArg = i > 0 ? args[i - 1] : null;
if (previousArg != null && CommonOptions.PropertiesOption.Aliases.Contains(previousArg))
{
return false;
}
return true;
}
}
Expand Down
22 changes: 22 additions & 0 deletions test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTestfromCsproj.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,28 @@ public void PropertiesEndingWithDotDllShouldNotFail(string property)
result.ExitCode.Should().Be(1);
}

[Fact]
public void DistributedLoggerEndingWithDotDllShouldBePassedToMSBuild()
{
var testProjectDirectory = CopyAndRestoreVSTestDotNetCoreTestApp([]);

CommandResult result = new DotnetTestCommand(Log, disableNewOutput: true)
.WithWorkingDirectory(testProjectDirectory)
.Execute(ConsoleLoggerOutputNormal.Concat(["-dl:my.dll"]));

if (!TestContext.IsLocalized())
{
// This ensures that this was passed to MSBuild and not vstest.console.
result.StdOut.Should().Contain("error MSB1021: Cannot create an instance of the logger my.dll.");
}
else
{
result.StdOut.Should().Contain("MSB1021");
}

result.ExitCode.Should().Be(1);
}

private string CopyAndRestoreVSTestDotNetCoreTestApp(object[] parameters, [CallerMemberName] string callingMethod = "")
{
// Copy VSTestCore project in output directory of project dotnet-vstest.Tests
Expand Down
Loading