-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add a template for servicing pull requests #51512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
baronfel
wants to merge
1
commit into
dotnet:main
Choose a base branch
from
baronfel:create-servicing-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| --- | ||
| name: Request Servicing Approval | ||
| about: Prepare a PR that needs to be approved by .NET Servicing, for example to apply to a released version of the .NET SDK. | ||
| --- | ||
|
|
||
| <!-- | ||
| Please use this template when creating a pull request that requires servicing approval. | ||
| After creating the PR, apply the "Servicing-consider" label so that it can be located and | ||
| reviewed by the servicing group. | ||
| You can also send mail if an asynchronous review is preferred. | ||
| --> | ||
|
|
||
| Fixes #<issue_number> | ||
|
|
||
| ## Customer Issue | ||
|
|
||
| <!-- Describe the impact of the issue here. Be as customer-focused as possible. Customer Impact is a key part of the servicing approval rubric. Make sure to think about how frequent the issue is, how many customers it affects, and the ease/availability of a workaround. --> | ||
|
|
||
| ## Description | ||
|
|
||
| <!-- Describe the changes made in this PR at a high level. Remember to, as a rule, keep changes as targeted as possible for servicing-fixes. Push any refactoring to in-development branches. --> | ||
|
|
||
| ## Was this a regression? | ||
|
|
||
| - [ ] Yes | ||
| - [ ] No | ||
|
|
||
| ## Testing | ||
|
|
||
| <!-- Describe the testing that has been done to validate the changes in this PR. --> | ||
|
|
||
| ## Risk | ||
|
|
||
| <!-- Describe the risk associated with this PR. For example, is it low risk because it only affects a small area of code, or high risk because it changes fundamental behavior? --> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent hyphenation: 'servicing-fixes' should be 'servicing fixes' to match the style used elsewhere in the template (e.g., line 3 uses 'a released version' without hyphenation for compound modifiers after nouns).