Skip up-to-date optimization in dotnet-run-file when there are #:project directives
#52062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses issue #52057 by disabling the up-to-date optimization in dotnet-run-file when #:project directives are present in the source file. The up-to-date check cannot currently detect changes in referenced projects, so always rebuilding when project directives are present ensures correctness.
Key changes:
- Added a check in
NeedsToBuild()to skip the up-to-date optimization when project directives exist - Added a comprehensive test validating that projects with
#:projectdirectives always rebuild, even when the main file hasn't changed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/Run/VirtualProjectBuildingCommand.cs | Added early return in NeedsToBuild() to force rebuilding when CSharpDirective.Project directives are detected |
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Added UpToDate_ProjectReferences test verifying that changes in referenced projects are picked up through forced rebuilds |
jjonescz
changed the title
#:project directives#:project directives
333fred
approved these changes
Dec 8, 2025
RikkiGibson
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52057.