Port sdk-diff-tests and license-scan pipelines to 1ES pipeline templates #52735
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ports the sdk-diff-tests and license-scan pipelines to use 1ES pipeline templates, which is required for production pipelines. The changes migrate from standard Azure Pipelines to the 1ES.Official.PipelineTemplate structure.
Changes:
- Added 1ES pipeline template resources and converted pipelines to use the
extendsstructure - Migrated artifact publishing from
publishtask totemplateContext.outputsfor 1ES compatibility - Restructured pipeline definitions to use stages/jobs hierarchy required by 1ES templates
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/SourceBuild/content/eng/pipelines/vmr-license-scan.yml | Converted license scan pipeline to use 1ES template with extends structure, added SDL configuration, and wrapped jobs in stages |
| src/SourceBuild/content/eng/pipelines/templates/jobs/sdk-diff-tests.yml | Migrated artifact publishing from publish task to templateContext outputs for 1ES compatibility and removed pool configuration |
| src/SourceBuild/content/eng/pipelines/source-build-sdk-diff-tests.yml | Converted sdk-diff-tests pipeline to use 1ES template structure with extends, added SDL configuration, and updated template references |
| options: '--memory=6g' | ||
| pool: | ||
| name: NetCore1ESPool-Svc-Internal | ||
| demands: ImageOverride -equals 1es-ubuntu-2204 |
There was a problem hiding this comment.
The pool configuration for the LicenseScan job is using the old Azure Pipelines format with demands: ImageOverride -equals 1es-ubuntu-2204 instead of the 1ES pipeline template format. When using 1ES pipeline templates, pool specifications should use the image and os fields, as seen in other 1ES pipelines in this repository (e.g., src/SourceBuild/content/eng/pipelines/templates/stages/vmr-scan.yml lines 8-11). The pool configuration should be updated to:
pool:
name: NetCore1ESPool-Svc-Internal
image: 1es-ubuntu-2204
os: linux
| demands: ImageOverride -equals 1es-ubuntu-2204 | |
| image: 1es-ubuntu-2204 | |
| os: linux |
| condition: or(eq(variables['Build.SourceBranch'], 'refs/heads/main'), startsWith(variables['Build.SourceBranch'], 'refs/heads/release')) | ||
| pool: | ||
| name: NetCore1ESPool-Svc-Internal | ||
| demands: ImageOverride -equals 1es-ubuntu-2204 |
There was a problem hiding this comment.
The pool configuration for the Publish_Test_Results_PR job is using the old Azure Pipelines format with demands: ImageOverride -equals 1es-ubuntu-2204 instead of the 1ES pipeline template format. When using 1ES pipeline templates, pool specifications should use the image and os fields, as seen in other 1ES pipelines in this repository (e.g., src/SourceBuild/content/eng/pipelines/templates/stages/vmr-scan.yml lines 8-11). The pool configuration should be updated to:
pool:
name: NetCore1ESPool-Svc-Internal
image: 1es-ubuntu-2204
os: linux
| demands: ImageOverride -equals 1es-ubuntu-2204 | |
| image: 1es-ubuntu-2204 | |
| os: linux |
2 participants
Ports the changes from #44238