Don't import BundledVersions multiple times #52774
Merged
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request prevents multiple imports of the Microsoft.NETCoreSdk.BundledVersions.props file by using NetCoreSdkRoot as a sentinel property to track whether the file has already been imported.
Changes:
- Added
'$(NetCoreSdkRoot)' == ''condition to Import statements in two files that import BundledVersions.props - Changed
NetCoreSdkRootproperty assignment in the generated BundledVersions.props from conditional to unconditional
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.props | Added condition to prevent re-importing BundledVersions.props if already imported |
| src/Tasks/Microsoft.NET.Build.Tasks/sdk/Sdk.BundledVersions.props | Added condition to prevent re-importing BundledVersions.props if already imported |
| src/Layout/redist/targets/GenerateBundledVersions.targets | Changed NetCoreSdkRoot to always be set (removing conditional), ensuring it works as a reliable sentinel for import tracking |
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.BeforeCommon.props
Outdated
Show resolved
Hide resolved
…BeforeCommon.props Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
akoeplinger
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids issues when the Sdk.BundledVersions.props file gets manually imported.