Remove outdated TODO comment from Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#53688
Merged
akoeplinger merged 1 commit intomainfrom Apr 10, 2026
Merged
Remove outdated TODO comment from Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#53688akoeplinger merged 1 commit intomainfrom
akoeplinger merged 1 commit intomainfrom
Conversation
…eResolution.targets The condition got fixed in 2304819 but the comment wasn't removed.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an outdated TODO comment in Microsoft.NET.Sdk.FrameworkReferenceResolution.targets that references a now-resolved condition (per the linked commit), keeping the targets file accurate and reducing confusion during future maintenance.
Changes:
- Deleted a stale TODO comment referencing #49917 in the framework reference resolution targets.
This was referenced Apr 3, 2026
Open
Member
Author
|
@ericstj mind taking a look? thanks |
ViktorHofer
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition got fixed in 2304819 but the comment wasn't removed.
Stumbled over this while looking at an unrelated issue