Clean up temp sarif file after validation in CI builds#53731
Merged
jeffhandley merged 2 commits intodotnet:mainfrom Apr 9, 2026
Merged
Clean up temp sarif file after validation in CI builds#53731jeffhandley merged 2 commits intodotnet:mainfrom
jeffhandley merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Deletes the transient temp-*.sarif file produced during validateOnly (CI) runs of GenerateDocumentationAndConfigFiles so the source tree isn’t left with an untracked build artifact.
Changes:
- Delete the generated temp SARIF file immediately after validation completes in
validateOnlymode.
Delete the temp-*.sarif file written to the source directory after validation completes. The file is only needed transiently for comparison and serves no purpose afterward. Fixes dotnet#53729
MichaelSimons
force-pushed
the
fix/cleanup-temp-sarif
branch
from
ee0173f to
2e3f715
Compare
jeffhandley
approved these changes
Apr 9, 2026
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
@krwq and I looked at this together. Looks good; thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete the
temp-*.sariffile written to the source directory after validation completes. The file is only needed transiently for comparison and serves no purpose afterward.Fixes #53729