Merge dotnet/templating catch-up: 4 commits missed in Phase 1#53734
Merged
MichaelSimons merged 4 commits intodotnet:mainfrom Apr 7, 2026
Merged
Merge dotnet/templating catch-up: 4 commits missed in Phase 1#53734MichaelSimons merged 4 commits intodotnet:mainfrom
MichaelSimons merged 4 commits intodotnet:mainfrom
Conversation
After the Newtonsoft.Json → System.Text.Json migration (dotnet/templating#9956), MockTemplateInfo's explicit ITemplateInfo.Tags and CacheParameters implementations throw NotImplementedException. Newtonsoft never hit these during serialization, but System.Text.Json walks all interface properties, causing TemplateDiscoveryMetadata.ToJObject() to crash in the SDK's CacheSearchCoordinatorTests. Return empty dictionaries instead of throwing. Both properties are [Obsolete] and the mock's real data lives in TagsCollection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Commit migrated from dotnet/templating@2eeb888
Commit migrated from dotnet/templating@a7fa48a
Commit migrated from dotnet/templating@89cd903
Commit migrated from dotnet/templating@9c09d76
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates four missed pre-Phase-1 dotnet/templating commits into dotnet/sdk, covering a test mock update to support System.Text.Json serialization and several operational updates to the templating search-cache pipeline (schedule + framework selection).
Changes:
- Update
MockTemplateInfoto avoid exceptions duringSystem.Text.Jsonserialization ofITemplateInfo. - Adjust
eng/pipelines/search-cache-pipeline.ymlto run daily and resolveNetCurrentfor running the cache updater tool.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/TemplateEngine/Microsoft.TemplateEngine.Mocks/MockTemplateInfo.cs | Changes obsolete ITemplateInfo members to stop throwing during serialization. |
| eng/pipelines/search-cache-pipeline.yml | Changes schedule to daily and updates the cache updater invocation to use the resolved NetCurrent framework. |
NikolaMilosavljevic
approved these changes
Apr 7, 2026
MiYanni
approved these changes
Apr 7, 2026
Member
Author
|
/ba-g known windows agent machine outage. Other legs provide sufficient coverage for this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates 4 commits from
dotnet/templatingthat were not included in the Phase 1 merge (#53647).Commits
All commits follow the Phase 1 conventions:
test/→test/TemplateEngine/,search-cache-pipeline.yml→eng/pipelines/search-cache-pipeline.yml)#NNNreferences fully qualified todotnet/templating#NNNCommit migrated from https://github.com/dotnet/templating/commit/<sha>This accounts for all commits on
dotnet/templatingmain that touch migrated paths (src/,test/,tools/,template_feed/,docs/,dotnet-template-samples/,Microsoft.TemplateEngine.sln,search-cache-pipeline.yml) since the Phase 1 cutoff.Related: #53647