Remove feature flags for `#:include` and `#:exclude` by jjonescz · Pull Request #53775 · dotnet/sdk

jjonescz · 2026-04-09T10:25:38Z

Follow up on #52347.

Copilot

Pull request overview

This PR removes the feature-flag gating for the #:include / #:exclude directives in file-based apps, following up on #52347 and making the directives available without additional MSBuild properties.

Changes:

Removes the feature-flag enforcement logic for #:include/#:exclude (and transitive directive processing) from VirtualProjectBuilder.
Updates CLI tests to no longer set the removed feature flags and removes the now-obsolete feature-flag test.
Removes the ExperimentalFeatureDisabled localized resource string and updates the dotnet run file documentation accordingly.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/dotnet.Tests/CommandTests/Run/RunFileTests.cs	Removes flag setup and the flag-gating test; adds a new test around the remaining item-mapping feature flag.
test/dotnet.Tests/CommandTests/Project/Convert/DotnetProjectConvertTests.cs	Removes now-unnecessary feature-flag properties from conversion tests that use include/exclude directives.
src/Microsoft.DotNet.ProjectTools/VirtualProjectBuilder.cs	Removes directive feature-flag checks so include/exclude/transitive processing is no longer gated.
src/Microsoft.DotNet.ProjectTools/Resources.resx	Removes the `ExperimentalFeatureDisabled` resource string.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.zh-Hant.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.zh-Hans.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.tr.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.ru.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.pt-BR.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.pl.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.ko.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.ja.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.it.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.fr.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.es.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.de.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Microsoft.DotNet.ProjectTools/xlf/Resources.cs.xlf	Removes the `ExperimentalFeatureDisabled` localized entry.
src/Cli/Microsoft.DotNet.FileBasedPrograms/InternalAPI.Unshipped.txt	Drops internal API entries for the removed experimental-flag constants.
src/Cli/Microsoft.DotNet.FileBasedPrograms/FileLevelDirectiveHelpers.cs	Removes the now-unused experimental-flag constant definitions for include/exclude/transitive.
documentation/general/dotnet-run-file.md	Removes documentation that stated `#:include`/`#:exclude`/transitive were gated by experimental feature flags.

jjonescz · 2026-04-14T09:14:22Z

@333fred @RikkiGibson @MiYanni for reviews, thanks

333fred · 2026-04-14T17:02:22Z

 For a given `dotnet run file.cs`, we include directives from the current entry point file (`file.cs`) and all other non-entry-point C# files,
 specifically from all `Compile` items included in the project, no matter whether the `Compile` items are specified in some MSBuild code or inferred from `#:include`.
-(Processing directives from other files is currently gated under a feature flag that can be enabled by setting the MSBuild property `ExperimentalFileBasedProgramEnableTransitiveDirectives=true`.)
+


Was turning this single paragraph into two paragraphs intended?

No, will revert, thanks.

RikkiGibson · 2026-04-14T18:45:00Z

    {
-        public const string ExperimentalFileBasedProgramEnableIncludeDirective = nameof(ExperimentalFileBasedProgramEnableIncludeDirective);
-        public const string ExperimentalFileBasedProgramEnableExcludeDirective = nameof(ExperimentalFileBasedProgramEnableExcludeDirective);
-        public const string ExperimentalFileBasedProgramEnableTransitiveDirectives = nameof(ExperimentalFileBasedProgramEnableTransitiveDirectives);


do want to call out that I think the editor still needs changes to handle transitive directives properly. So today it will see #: and assume the file is an entry point (depending on the order things load in).

I am comfortable with moving forward on that change and just making sure we expedite it properly. But may want to extract this bit to separate PR, if our goal was to only remove experimental flags for these, for scenarios where we expect editor tooling to work.

@DamianEdwards what would you like to do about the transitive feature flag given IDE doesn't implement support for that yet?

@RikkiGibson what's the plan for integrating your entry-point detection changes? Is that the change you're referring to when you said:

I am comfortable with moving forward on that change and just making sure we expedite it properly.

I am concerned about missing the boat here a bit as the next train is 10.0.400 (or 11 previews) and that's not until August+. It would be super unfortunate if we're able to get the editor experience changes done well before then but we can't enable it by default in the SDK.

That said, pulling the removal of flag on the transitive directive feature in the SDK into a separate PR seems like the prudent thing to do given the current state.

dotnet/roslyn#83185

RikkiGibson · 2026-04-14T18:48:24Z

        }
    }

-    private void CheckDirectives(


So some version of this check, is going to return, when #:ref support merges behind experimental flag? The churn doesn't specifically worry me, just wanted to understand what to expect.

yes, and since I just merged the #:ref change, I'm going to merge base branch back here and this diff should become smaller

RikkiGibson

Done review pass. Let's just work out how to deal with transitive directives and then should be able to get this merge ready.

jjonescz · 2026-04-17T07:53:31Z

@RikkiGibson for another look, thanks

Remove feature flags for #:include and #:exclude

c7668c2

jjonescz requested review from a team and Copilot April 9, 2026 10:25

jjonescz added the Area-run-file Items related to the "dotnet run <file>" effort label Apr 9, 2026

Copilot started reviewing on behalf of jjonescz April 9, 2026 10:26 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Comment thread test/dotnet.Tests/CommandTests/Run/RunFileTests.cs Outdated

jjonescz added 2 commits April 9, 2026 15:01

Fixup a test

6be0b80

Remove opt in for the mapping property too

c3185b6

333fred approved these changes Apr 14, 2026

View reviewed changes

RikkiGibson reviewed Apr 14, 2026

View reviewed changes

jjonescz added 3 commits April 15, 2026 10:34

Merge branch 'release/10.0.3xx' into sprint-include-not-experimental

c5abd10

Revert paragraph split

7fdf23b

Revert resource string removal

d1a16bc

jjonescz force-pushed the sprint-include-not-experimental branch from e37e4bf to d1a16bc Compare April 15, 2026 08:58

jjonescz added 2 commits April 15, 2026 11:34

Fixup after merge

2b0724d

Fixup after merge

232b4f2

This was referenced Apr 15, 2026

[Known Build Error] It_publishes_the_project_with_a_refs_folder_and_correct_deps_file - mscorlib.dll path mismatch #53886

Open

[Known Build Error] C++/CLI tests fail on VS 2026 Helix machines - MSB8020 v143 platform toolset not found #53887

Open

RikkiGibson mentioned this pull request Apr 15, 2026

File-based apps: Adjust heuristics to properly handle transitive directives dotnet/roslyn#83185

Open

Re-introduce a feature flag for transitive directives

242509c

jjonescz requested a review from RikkiGibson April 16, 2026 09:11

Improve

efe50eb

MiYanni approved these changes Apr 16, 2026

View reviewed changes

Conversation

jjonescz commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

jjonescz commented Apr 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjonescz Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RikkiGibson left a comment

Choose a reason for hiding this comment

Uh oh!

jjonescz commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jjonescz Apr 15, 2026 •

edited

Loading