Re-apply OTel changes from PR #53181 and revert S.CL version#53816
Closed
MiYanni wants to merge 3 commits intodotnet:mainfrom
Closed
Re-apply OTel changes from PR #53181 and revert S.CL version#53816MiYanni wants to merge 3 commits intodotnet:mainfrom
MiYanni wants to merge 3 commits intodotnet:mainfrom
Conversation
This re-applies the OpenTelemetry telemetry changes that were reverted in PR dotnet#53788, without re-applying the xUnit v3 migration (PR dotnet#52930). Key changes: - Replace ApplicationInsights with OpenTelemetry for telemetry - Add ITelemetryClient interface replacing ITelemetry - Add TelemetryClient implementation using OTel - Update ITelemetryFilter to use typed overloads instead of object parameter - Update TelemetryFilter with new Filter implementations - Remove ApplicationInsights NuGet dependency - Add OpenTelemetry NuGet packages - Delete PersistenceChannel telemetry infrastructure (no longer needed) - Delete PerformanceLog infrastructure (replaced by OTel) - Move test files to TelemetryTests subfolder - Various nullable annotation improvements Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: MiYanni <17788297+MiYanni@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: MiYanni <17788297+MiYanni@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-applies the OpenTelemetry telemetry changes that were reverted in PR #53788, without re-applying the xUnit v3 migration (PR #52930). Additionally, reverts the System.CommandLine version as to allow the dotnet CLI to function properly (as seen in test failures using the new package version).
Key changes:
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Co-authored-by: MiYanni 17788297+MiYanni@users.noreply.github.com