Properly ingest dotnetup data after data-x-migration#54051
Draft
nagilson wants to merge 7 commits intodotnet:release/dnupfrom
Draft
Properly ingest dotnetup data after data-x-migration#54051nagilson wants to merge 7 commits intodotnet:release/dnupfrom
dotnetup data after data-x-migration#54051nagilson wants to merge 7 commits intodotnet:release/dnupfrom
Conversation
very wip code, but: spans don't get consumed by the data-x-platform only events which go into the 'traces' table so we need to send this data as a 'trace' (event) but also still have the spans so we can use the aspire like dashboards I believe duration and other span properties dont get added to the activities so we need to add them ourselves.
… and activity also add test failing if the code tries settag
we observe spotty behavior by running at scale in ci for now!
nagilson
commented
Apr 22, 2026
| op.Tag("gc.deleted_count", deleted.Count); | ||
| op.Tag("gc.failed_count", failedCount); | ||
| op.Tag("gc.failed_path", lastFailedPath); | ||
| op.Tag("gc.status", failedCount > 0 ? "error" : "ok"); |
Member
Author
There was a problem hiding this comment.
why do we set status here twice ?
nagilson
commented
Apr 22, 2026
| DotnetupDebugHelper.HandleDebugSwitch(ref args); | ||
|
|
||
| // Start root activity for the entire process | ||
| using var rootOp = DotnetupTelemetry.Instance.StartTrackedProcess("dotnetup"); |
Member
Author
There was a problem hiding this comment.
lets also not do this if telemetry is enabled probably ? or is this a no op? need to look.
nagilson
commented
Apr 23, 2026
| @@ -216,8 +215,8 @@ private void ValidateInstallPath(string installPath, PathSource pathSource, stri | |||
| // Block system-managed install paths — dotnetup should not install there | |||
| if (InstallPathClassifier.IsAdminInstallPath(installPath)) | |||
Member
Author
There was a problem hiding this comment.
we might want error to be prefixed with the root event namespace e.g. dotnetup/instal/download etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #52785
History:
#52792 added working telemetry with an app insights board to
dotnetupbut used a separate implementation as the SDK did not use otel (not native aot)#53343 moved to the official key which broke and made all data get lost (intentional)
#53181 implemented OpenTelemetry usage within the .NET SDK.
This PR: