Avoid reporting CA1859 for properties with setter more accessible than getter#54122
Open
Alex-Sob wants to merge 4 commits intodotnet:mainfrom
Open
Avoid reporting CA1859 for properties with setter more accessible than getter#54122Alex-Sob wants to merge 4 commits intodotnet:mainfrom
Alex-Sob wants to merge 4 commits intodotnet:mainfrom
Conversation
This was referenced Apr 28, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #50957
Issue
'CA1859: Use concrete types when possible for improved performance' rule is reported for properties with setter more accessible than getter, for example:
While properties with setter that is more accessible than getter should probably be avoided, they are legal in C# and the analyzer should avoid reporting CA1859 in such cases.
Changes
Fixed
UseConcreteTypeAnalyzerto avoid report CA1859 if a property has setter that is more accessible than getter.Removed
bool setterparameter fromUseConcreteTypeAnalyzer.Collector.CanUpgrademethod since it's only used withsetter: false.Added
[StringSyntax("C#-test")]attribute to helper methods inUseConcreteTypeTestsclass that run a test. This enables syntax highlighting to all tests in that class.Added a unit test.