Reenable PublishDotnetAot target#54175
Merged
Merged
Conversation
NikolaMilosavljevic
requested review from
JeremyKuhne,
MiYanni,
Copilot and
marcpopMSFT
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables the PublishDotnetAot MSBuild target in the redist layout generation so the SDK build once again publishes the dotnet-aot NativeAOT shared library into the SDK layout (for supported host-native RIDs).
Changes:
- Re-enabled the
PublishDotnetAottarget by restoring its original RID-based condition (instead ofCondition="false").
Member
Author
|
/azp run sdk-unified-build |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Split Restore and Publish into separate MSBuild invocations in the PublishDotnetAot target. Use RuntimeIdentifiers (plural) for Restore to force NuGet to add the RID-specific target to project.assets.json, even after Arcade's centralized restore already ran without RuntimeIdentifier. Remove IntermediateOutputPath to avoid propagating it to ProjectReferences. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
NikolaMilosavljevic
force-pushed
the
aot.fix
branch
from
acfa6f4 to
929ddb6
Compare
Member
Author
|
OK - this seems to be working now. Ready for review - @JeremyKuhne @marcpopMSFT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This target was disabled with #54067 as it was believed to have caused some build issues.
First attempt to reenable it included a "required" fix - #54114
However, that change was incorrect and caused several jobs to fail in official CI run.
I am now just reenabling the original target code, as it appears to be working fine.
Verification
https://dev.azure.com/dnceng-public/public/_build/results?buildId=1407885&view=results
Single failure in Mac OS leg seems to be intermittent and unrelated.