Skip Helix tests when build step fails#54232
Merged
Merged
Conversation
Remove 'condition: succeededOrFailed()' from all 'Run Tests in Helix' steps in eng/build.yml and eng/build-pr.yml. Without an explicit condition, Azure Pipelines defaults to 'succeeded()', which skips the test step when the preceding build step fails. This avoids wasting Helix resources on tests that cannot succeed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SDK’s Azure Pipelines templates to avoid running Helix test submissions when the preceding build step fails, reducing wasted Helix capacity on runs that are unlikely to succeed.
Changes:
- Removed
condition: succeededOrFailed()from all “Run Tests in Helix” steps ineng/build.yml. - Removed
condition: succeededOrFailed()from all “Run Tests in Helix” steps ineng/build-pr.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/build.yml | Removes the explicit “run even on failure” condition from Helix test steps so they only run on successful builds. |
| eng/build-pr.yml | Same change as eng/build.yml, applied to PR builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
btw, tested internally and worked perfectly: https://dev.azure.com/dnceng/internal/_build/results?buildId=2969902&view=results The build failed, finished in 18 minutes, and no tests were run |
baronfel
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 'condition: succeededOrFailed()' from all 'Run Tests in Helix' steps in eng/build.yml and eng/build-pr.yml. Without an explicit condition, Azure Pipelines defaults to 'succeeded()', which skips the test step when the preceding build step fails. This avoids wasting Helix resources on tests that cannot succeed.