Make a RID-suffixed copy of the dotnetup AOT binary for Arcade publishing#54422
Open
dsplaisted wants to merge 1 commit into
Open
Make a RID-suffixed copy of the dotnetup AOT binary for Arcade publishing#54422dsplaisted wants to merge 1 commit into
dsplaisted wants to merge 1 commit into
Conversation
…hing Previously, we were trying to have a blob filename different from the filename of the artifact that was produced, because for the downloads we need a RID-specific URL (ie ending in dotnetup-<rid>[.exe]). However, it appears that Arcade doesn't support having the artifact filename differ from the blob filename. So after publish we make a copy of the dotnetup executable with the RID appended to it, and use that as the Artifact for Arcade. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dotnetup NativeAOT publishing pipeline so Arcade can publish RID-specific blobs whose artifact filename matches the desired blob filename (e.g., dotnetup-win-x64.exe). It does this by producing a RID-suffixed copy of the published executable and updating signing/publishing metadata to use that copy.
Changes:
- Add an MSBuild target in
dotnetup.csprojto copy the published binary todotnetup-<rid>[.exe]afterPublish. - Update signing artifact discovery and signing rules to use the RID-suffixed dotnetup binary.
- Update publishing logic to set
RelativeBlobPathfor the RID-suffixed dotnetup binary and its.sha512sidecar.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Installer/dotnetup/dotnetup.csproj | Creates a RID-suffixed copy of the published NativeAOT executable after publish. |
| src/Installer/dotnetup.Library/Program.cs | Adjusts dotnetup entrypoint class visibility and adds XML docs. |
| eng/Signing.props | Signs and registers the RID-suffixed dotnetup publish output as the blob artifact input. |
| eng/Publishing.props | Assigns RID-suffixed RelativeBlobPath metadata for the dotnetup blob and checksum. |
Member
Author
|
/ba-g Flaky SDK template engine test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were trying to have a blob filename different from the filename of the artifact that was produced, because for the downloads we need a RID-specific URL (ie ending in dotnetup-[.exe]).
However, it appears that Arcade doesn't support having the artifact filename differ from the blob filename. So after publish we make a copy of the dotnetup executable with the RID appended to it, and use that as the Artifact for Arcade.